StrataFrame Forum

HELP! Cannot enter datagridview using BBS on new record without erroring on rentrant call to Setcurrentcelladdresscore

http://forum.strataframe.net/Topic26560.aspx

By Charles R Hankey - 3/22/2010

I have a simple DGV using as a datasource a BBS connected to a childbo. Relationships all setup properly. Parent filters children. All data is loaded in parentform loading.



Starting with empty data in all tables.



I have tried setting Setdirtyonedit of the childbo instance to false and to true.



I can create a new parent, but on entering any grid I get the following error.



I know I'm missing something very basic here but as I have a dozen of these grids on my form this is a showstopper.



Would really appreciate any suggestions as to what I should be looking at and just what the tricks are to getting a datagridview and a bbs to play nice. For some reason I thought I had this all working and it does seem to not error if the parent isn't new, but on a new parent - BOOM



InvalidOperationException

Operation is not valid because it results in a reentrant call to the SetCurrentCellAddressCore function.



Source : System.Windows.Forms



Stack Trace:

at System.Windows.Forms.DataGridView.SetCurrentCellAddressCore(Int32 columnIndex, Int32 rowIndex, Boolean setAnchorCellAddress, Boolean validateCurrentCell, Boolean throughMouseClick)

at System.Windows.Forms.DataGridView.DataGridViewDataConnection.MatchCurrencyManagerPosition(Boolean scrollIntoView, Boolean clearSelection)

at System.Windows.Forms.DataGridView.DataGridViewDataConnection.ProcessListChanged(ListChangedEventArgs e)

at System.Windows.Forms.DataGridView.DataGridViewDataConnection.currencyManager_ListChanged(Object sender, ListChangedEventArgs e)

at System.Windows.Forms.CurrencyManager.OnListChanged(ListChangedEventArgs e)

at System.Windows.Forms.CurrencyManager.List_ListChanged(Object sender, ListChangedEventArgs e)

at System.ComponentModel.ListChangedEventHandler.Invoke(Object sender, ListChangedEventArgs e)

at MicroFour.StrataFrame.Business.BusinessBindingSource.OnListChanged(ListChangedEventArgs e)

at MicroFour.StrataFrame.Business.BusinessBindingSource.BusinessObject_IsDirtyChanged(Object sender, EventArgs e)

at MicroFour.StrataFrame.Business.BusinessLayer.raise_IsDirtyChanged(Object sender, EventArgs e)

at MicroFour.StrataFrame.Business.BusinessLayer.OnIsDirtyChanged(Boolean DirtyShouldBe)

at MicroFour.StrataFrame.Business.BusinessLayer.SetEditingState(BusinessEditingState EditState, Boolean RefreshControls)

at MicroFour.StrataFrame.Business.BusinessLayer.SetEditingState(BusinessEditingState EditState)

at MicroFour.StrataFrame.Business.BusinessLayer.Add(Boolean CheckSecurity)

at MicroFour.StrataFrame.Business.BusinessBindingSource.IBindingListView_AddNew()

at System.Windows.Forms.CurrencyManager.AddNew()

at System.Windows.Forms.DataGridView.DataGridViewDataConnection.AddNew()

at System.Windows.Forms.DataGridView.DataGridViewDataConnection.OnNewRowNeeded()

at System.Windows.Forms.DataGridView.OnRowEnter(DataGridViewCell& dataGridViewCell, Int32 columnIndex, Int32 rowIndex, Boolean canCreateNewRow, Boolean validationFailureOccurred)

at System.Windows.Forms.DataGridView.OnCellMouseDown(HitTestInfo hti, Boolean isShiftDown, Boolean isControlDown)

at System.Windows.Forms.DataGridView.OnCellMouseDown(DataGridViewCellMouseEventArgs e)

at System.Windows.Forms.DataGridView.OnMouseDown(MouseEventArgs e)

at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)

at System.Windows.Forms.Control.WndProc(Message& m)

at System.Windows.Forms.DataGridView.WndProc(Message& m)

at System.Windows.Forms.Control.ControlNativewindow.OnMessage(Message& m)

at System.Windows.Forms.Control.ControlNativewindow.WndProc(Message& m)

at System.Windows.Forms.Nativewindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
By Charles R Hankey - 3/22/2010

If I save the parent before entering any child grid, i do not get the error in Edit mode.
By Charles R Hankey - 3/22/2010

I've reproduced this in a sample app.  The issue (at least the first one) is creating a new customer and then without saving entering the grid to add a new sale in the datagridview.

The data retrieval is done with a sproc that will be created by the DDT package.

For anybody that does not have the DDT I am also attaching the scripts to create Gridtest.mdf and the two sprocs

TIA

By Charles R Hankey - 3/22/2010

Second problem in this sample :

On new the grid doesn't clear until the parent is saved.  Calling dgvSales.refresh() or .refreshedit() in the Afteraddnew of the CustomersBO seems to have no effect, but as soon as new customer is saved the grid shows the empty child grid. 

Tried setting SalesBO1 to Include in Add bu that isn't the answer either.

By Edhy Rijo - 3/22/2010

Hi Charles,



Also in your scripts you forgot to include the table scripts for Customers and Sales.



I have not worked with data grid, I use the list view for this kind of data entry, but I will check it out to see if I can help dig out this problem.
By Charles R Hankey - 3/22/2010

The probem seems to be that in AfterAddNew the bbsSales still has as _Businessobjectcurrentview the set of records based on the parent before the add.  Remember, the autofilter is on.  Perhaps the autofilter match current row doesn't play well with the BBS? 

If I add the line

me.SalesBO1.filter = "fk_Customers = -1"

it solves the problem for existing data but blows up when both tables are empty.

Edhy - here's the scripts for creating tables (sorry, thought the generated database script did that - should have checked it - I use DDT all the time so I'm script stupid )

By Edhy Rijo - 3/22/2010

Do not use the BO.autofilter it is not safe, I don't remember details but search the forum for more info.



In the CustomerBO1.Navigated add the this code below Me.dgvSales.Refresh() and try.



Me.SalesBO1.FillByParentPrimaryKey(Me.CustomersBO1.pk_Customers)
By Edhy Rijo - 3/22/2010

Charles,



Forgot to mention, remove all the code from the SalesBO1.ParentFormLoading().



I believe the problem was that the BO.AutoFilter option was filtering the data and causing some sort of thread invoke error. It is always better for you to handle your own filters.
By Charles R Hankey - 3/22/2010

Thanks for that suggestion. I hadn't really used the autofilter before but I liked the idea of not making a trip to the server on every navigate. Perhaps I could still pull all the data and then set filters manually.



I any case this does confirm that the combination of autofilter and BBS is the problem .



Perhaps Trent can confirm?



I'll search the forum for references to this problem.



When get the sample working reliably I'll post it in the contributed samples so somebody else won't have to go through the day I've had w00t


By Charles R Hankey - 3/22/2010

The suggestion to search was a good one !

I think i may have this solved by putting the line

me.customersBO1.FilterChildrecords()

in the afteraddnew. 

Fixes the problem in adding on empty data tables and in clearing existing child data on adding a new with exisitng data

So far so good.  I'll try it in my big app and if it tests out I'll post the sample with comments for anybody else who might want to do this.

BigGrin

By Edhy Rijo - 3/22/2010

Charles R Hankey (03/22/2010)
Thanks for that suggestion. I hadn't really used the autofilter before but I liked the idea of not making a trip to the server on every navigate. Perhaps I could still pull all the data and then set filters manually.




You can use either approach, but it all depend on your application's business rule, ex: if you have multiple users working on the same time, then the filter approach could be problematic, since a user may be modifying a record that has been modified and I don't know how the SF concurrency checking will work in that case.
By Dustin Taylor - 3/23/2010

Glad you guys got it worked out!

Yep, you have to be carefull on filters as most uses of a BO will go off of the CurrentView, and any changes that bring things into or out of the filter in the middle of a process could cause wonky results (to put it in technical terms.)

To answer Edhy's comment regarding collision detection, collision detection in this environment should still work fine, you would just be opening yourself up to more collisions the longer you went between pulling data from the database and saving the changes back. In other words, it would likely be faster from an access perspective to pull everything you may need back to the database and the save it when you are finished, but if this is a form they will be using for 10 or 20 minutes before hitting the "save" button, you'll want to account for that based on how your users are going to use the system (i.e. how likely it is that someone will edit the same record within that 10 or 20 minutes). 

Our medical application does something similar when you edit a patient record. Since patients are the central component of the system, there is quite a bit of data related to each patient's record.  To account for this, we've split up the editing functions into areas of common use ("Registration" for demographic info, "Ledger" for financial transactions, "Media" for media files, etc), and handle the saving slightly differently as appropriate for each area.

The "Registration" section, for example, pulls all registration information (from about 10 tables) related to the patient at once, and lets you edit any or all of it before hitting save. If you ever navigate off the "Patient Registration" page, however, we ask you to save your changes to persist them back to the database.  In the case of any data collisions, we just use the standard SF Data Collision form and methodolgy, we've just designed those areas of the system to minimize the collisions wherever possible.

By Charles R Hankey - 3/23/2010

Thanks Dustin



I really like the automatic child filtering ( with the caveat about collisions ) and I'm delighted that the one line of code in the parent's AfterAddNew solved the problems I was having.



I'm going to post the sample I created (and maybe at a couple of other parent/child things) so others can see the relative merits of some of these techniques.