By Marcel Heitlager - 6/14/2012
Hi,
For some reason when I try to save data to two tables during a transaction save, sometimes the transaction only commits one of the tables. This is on a website. It happens when a person might put a payment through and the entire transaction fails, and rolls back for some reason. Then the person will try it again within a couple of minutes, and the transaction only commits the data to the 2nd save. See below:
'-- first generate a unique transaction key
Dim lcTransactionKey As String = AES.BOL.Base.Utils.NewSeqGuid().ToString
Try
TransactionBegin(Me.OPPaymentDetail.DataSourceKey, lcTransactionKey, IsolationLevel.ReadCommitted)
'-- First save data to the contact information table - This save Fails
Me.OPPaymentDetail.Save(True, lcTransactionKey)
'-- next get the primary key value and save to ACH detail table - This save Succeeds
Me.OPACHInfoBO.ah_op_Key = Me.OPPaymentDetail.GetPostSavePrimaryKeyValue(-1).ToString
Me.OPACHInfoBO.Save(True, lcTransactionKey)
TransactionCommit(Me.OPPaymentDetail.DataSourceKey, lcTransactionKey)
Return True
Catch ex As Exception
TransactionRollback(Me.OPPaymentDetail.DataSourceKey, lcTransactionKey)
Me.SendTransactionReportError()
Return False
End Try
It seems the 2nd transaction always commits, but the first doesn't.
It's running on SQL Server Express 2005, Windows Server 2003. Could it be some memory cache issue?
Thanks,
Marcel
|
By Edhy Rijo - 6/14/2012
Hi Marcel,
Your transaction looks just fine, except that I would put a condition to the Me.OPPaymentDetail.Save() as follow:
'-- first generate a unique transaction key
Dim lcTransactionKey As String = AES.BOL.Base.Utils.NewSeqGuid().ToString
Try
TransactionBegin(Me.OPPaymentDetail.DataSourceKey, lcTransactionKey, IsolationLevel.ReadCommitted)
'-- First save data to the contact information table - This save Fails
If Me.OPPaymentDetail.Save(True, lcTransactionKey) = MicroFour.StrataFrame.Data.SaveUndoResult.Success Then
'-- next get the primary key value and save to ACH detail table - This save Succeeds
Me.OPACHInfoBO.ah_op_Key = Me.OPPaymentDetail.GetPostSavePrimaryKeyValue(-1).ToString
Me.OPACHInfoBO.Save(True, lcTransactionKey)
End If
TransactionCommit(Me.OPPaymentDetail.DataSourceKey, lcTransactionKey)
Return True
Catch ex As Exception
TransactionRollback(Me.OPPaymentDetail.DataSourceKey, lcTransactionKey)
Me.SendTransactionReportError()
Return False
End Try
Also if your transaction is failing, you are not passing the ex Exception to your Me.SendTransactionReportError() so you don't really know why it may be failing.
|
By Marcel Heitlager - 6/18/2012
Thanks for you reply Edhy!
The thought didn't occur to me that I need to check for success. I always thought that the try/catch would trap for transaction failure automatically without the conditional and skip the rest.
Marcel
|
By Edhy Rijo - 6/19/2012
Hi Marcel,
You are welcome!!!
Marcel Heitlager (6/19/2012)
The thought didn't occur to me that I need to check for success. I always thought that the try/catch would trap for transaction failure automatically without the conditional and skip the rest.Marcel
Well, you are right, but since you don't know why the transaction is failing, then I make myself a habit to check the saving results in most of the time either way. Bottom line is that you need to try to figure out why the transaction is failing in order to present the user with a nice message and possible instructions on how to continue after the failing transaction.
|
|