StrataFrame Forum » StrataFrame Database Deployment Toolkit » Issues » BO Mapper Bug on FieldChanging event when allow null

BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Thu, 19 Jan 2017 11:22:21 GMT

I've come across a bug in BO Mapper when adding a FieldChanging event to a field that allows nulls. 
The following code was generated by the mapper. The "If value..." comparison always results to false, 
since the value was set equal to the e.FieldValue in the prior line, resulting in the item always 
being set to DBNull.

Set(ByVal value As System.Int32)
   Dim e As New TestBOFieldChangingEventArgs(TestBOFieldNames.ta_tst_id, value)
   Me.OnFieldPropertyChanging(Me, e)
   value = CType(e.FieldValue, System.Int32)
   If value <> CType(e.FieldValue, System.Int32) Then <---- Always False

        Me.CurrentRow.Item("ta_tst_id") = value
   Else
        Me.CurrentRow.Item("ta_tst_id") = DBNull.Value
   End IfEnd Set

Since I've configured the item to be Return Alternate on Null / Set Null on Alternate to 0 
I believe the if statement should be "If value <> 0 Then" as it does when adding a FieldChanged event.

The following code was generated by the mapper for a field where Alternate on null was set to 0 with
both FieldChanged and FieldChanging events. The FieldChanged event code uses "If value <> 0" while the
FieldChanging event code is using "If value <> Ctyp..."

Set(ByVal value As System.Int32)
   Dim e As New TestBOFieldChangingEventArgs(TestBOFieldNames.ta_tst_id, value)
   Dim llRaiseEvent As Boolean = False
   Dim loRow As DataRow = Me.CurrentRow
   Me.OnFieldPropertyChanging(Me, e)
       value = CType(e.FieldValue, System.Int32)
       If value <> 0 Then
           If Not loRow.Item("ta_tst_id").Equals(value) Then llRaiseEvent = True
       Else
           If Not loRow.Item("ta_tst_id").Equals(DBNull.Value) Then llRaiseEvent = True
       End If
       If value <> CType(e.FieldValue, System.Int32) Then
           loRow.Item("ta_tst_id") = value
       Else
           loRow.Item("ta_tst_id") = DBNull.Value
       End If
       If llRaiseEvent Then Me.OnFieldPropertyChanged(Me, New TestBOFieldChangedEventArgs(TestBOFieldNames.ta_tst_id))
End Set

RE: BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Thu, 19 Jan 2017 11:22:21 GMT

Thank you:)

RE: BO Mapper Bug on FieldChanging event when allow null

StrataFrame Team — Wed, 18 Jan 2017 11:47:59 GMT

Howdy Larry,

I got this fixed. I am currently unable to do a full build because our build server is in a state of flux, but I have updated the posted release with the VISX to include this fix. The change was made to the AddIns DLL, so that should be the only one you need to swap out.

http://forum.strataframe.net/FindPost33068.aspx

RE: BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Tue, 17 Jan 2017 16:28:57 GMT

Any chance this will get fixed? It's a pain to have to maintain custom code as a work around.

-Larry

RE: BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Fri, 04 Nov 2016 15:38:08 GMT

Is anyone from MicroFour monitoring the support forum??? It's been two months and this issue still exists. I wouldn't think it is that difficult of a fix to make.

-Larry

RE: BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Wed, 02 Nov 2016 21:20:30 GMT

PING! I'd really like to have a fix for this as it is causing problems for me.

-Larry

RE: BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Fri, 14 Oct 2016 10:56:48 GMT

Any estimate on when a fix will be available for this? It's a pain to have to work around it with custom code.

-Larry

RE: BO Mapper Bug on FieldChanging event when allow null

Larry Caylor — Tue, 04 Oct 2016 11:03:46 GMT

Ben,

How are you doing on that fix?

-Larry

RE: BO Mapper Bug on FieldChanging event when allow null

Keith Chisarik — Fri, 09 Sep 2016 12:31:17 GMT

Good to see a developer post. Hi Ben.

RE: BO Mapper Bug on FieldChanging event when allow null

Edhy Rijo — Tue, 06 Sep 2016 10:35:16 GMT

Hi Ben,

[quote][b]Ben Chase (9/6/2016)[/b][hr]Hrm. Good catch, Larry. I'll get that fixed for you.[/quote]
And for me too! Please :)

Thanks Larry!!

RE: BO Mapper Bug on FieldChanging event when allow null

StrataFrame Team — Tue, 06 Sep 2016 09:36:41 GMT

Hrm. Good catch, Larry. I'll get that fixed for you.