StrataFrame Forum » StrataFrame Application Framework - V1 » WinForms (How do I?) » Beta 1.6.5.1: ListView enhanced features....

Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 24 Sep 2008 09:29:17 GMT

Hi Trent,

First, thanks for all the enhancements done to the ListView, very impressive :)

I setup a form to test the ListView and found the following issues:

Moving the record pointer in the ToolStrip button does not update/refresh the ListView.
Creating a new record or modifying an existing one does not Refresh the ListView with the updated data.

I tested the functionality of the Add/Delete/Edit Objects and they all worked as expected.

One question, when using the ListView with a child BO, I may need to have buttons for Save/Undo if not using a childform object, would you consider adding a SaveObject/UndoObject as well for this case?

Please take a loot at the video in this link: http://www.progytech.com/videos/Beta_ListView\Beta_ListView.html

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 24 Sep 2008 09:29:17 GMT

Excellent! this much more than what I asked.

Thanks :P

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Wed, 24 Sep 2008 09:15:40 GMT

Done, it will be in the next update. We will post a 1.6.7 beta build in the next week or two, but this will be included. Here is the update:

[codesnippet]The ListView BeforeChildFormExecuted event now has a CancelAction parm on the event argument which allows several options. None, which would continue as normal, cancel the ChildFormDialog execution only, or cancel the dialog execution and undo any data changes related to the currently executed action (i.e. if adding a new record the new record would not be added). This gives the best of all worlds in regards to the potential needs to cancelling an automated ChildFormDialog execution.[/codesnippet]

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Tue, 23 Sep 2008 15:05:51 GMT

Hi Trent,

[quote][b]Trent L. Taylor (06/24/2008)[/b][hr]Oh, I suppose we could add a cancel parm. It was created so that there could be a centralized localization for pre-child form initialization code. Technically the action is already in progress (Delete would actually never hit this event). So either an Add or Edit will already be in progress. Adding a cancel shouldn't be too big of a deal, so I will add this to the list.[/quote]

I really have the need to be able to cancel out showing the childform dialog from the listview BeforeChildFormExecuted, I have not find a way to do this in a form without having to have all the listview code in the form to manage it.

Have you consider adding an e.Cancel parameter?

RE: Beta 1.6.5.1: ListView enhanced features....

Guillermo Vilas — Thu, 21 Aug 2008 05:22:26 GMT

I think the ListViewBeforeChildExecuteEventArgs event would be a good place to add extra params to send to the Child Form.

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Tue, 24 Jun 2008 09:44:15 GMT

Oh, I suppose we could add a cancel parm. It was created so that there could be a centralized localization for pre-child form initialization code. Technically the action is already in progress (Delete would actually never hit this event). So either an Add or Edit will already be in progress. Adding a cancel shouldn't be too big of a deal, so I will add this to the list.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Tue, 24 Jun 2008 08:24:39 GMT

Hi Trent,

In the latest update 1.6.6 a new event BeforeChildFormExecuted was added to the ListView control. I noticed that in the ListViewBeforeChildExecuteEventArgs there is no Cancel property to cancel any action handled by the ListView control.

Would it be necessary to add the e.Cancel property, or is there any other way to abort any of the 3 actions allow in the ListView (Add/Edit/Delete)?

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Fri, 23 May 2008 10:02:06 GMT

Just call the CheckRules method, not the CheckRulesOnRow. For example:

[codesnippet]If MyBo.CheckRules(True) Then
DialogResult = OK
End If[/codesnippet]

All of the error providers will then work, however, the InfoBox will not appear and this is by design. That logic is placed in the Save() of the BaseForm and creates a collection list...however, you can add this yourself very easily in your BaseBO. Just handle the BusinessRulesChecked event of the BaseBO, and you will probably want to have a property that determines if the InfoBox will be shown when there are broken rules (this too would be on your BaseBo). The only other property that you may consider adding or testing for is the parent form (or which ever form you may want the InfoBox to show within). But you would then call the InfoBox like this:

[codesnippet]If e.CountOfBrokenRulesAdditionalRows > 0 Then
InfoBox.ErrorBox(...)
Else
InfoBox.ErrorBox(...)
End If[/codesnippet]

You can look at the BaseForm in the Business assembly of the source to see what we do in that dialog.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Thu, 22 May 2008 14:31:59 GMT

Trent,

Refactoring my child forms, i have a situation with my current code in the ChildForm Save button:

[quote][codesnippet]

Private Sub cmdSave_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdSave.Click

'-- Use the form' Save method to force the Broken Rules to be check and show the Broken Rule InfoBox if needed.

If Me.Save() <> MicroFour.StrataFrame.Data.SaveUndoResult.Success Then

Exit Sub

ElseIf Me.Save() = MicroFour.StrataFrame.Data.SaveUndoResult.Success Then

Me.DialogResult = Windows.Forms.DialogResult.OK

Else

Me.PolicyBO1.Undo(MicroFour.StrataFrame.Business.BusinessUndoType.CurrentRowOnly)

Me.DialogResult = Windows.Forms.DialogResult.Cancel

End If

End Sub

[/codesnippet][/quote]

As you can see, I am using the Form's Save() to force the Broken Rules check and show the InfoBox. But intent to refactor it to simply check for broken rules and return a DialogResult.OK as it should be.

In the CustomerNodeEditor form this code is being used for the same reason:

[quote][codesnippet]

Private Sub cmdSave_Click(ByVal sender As Object, ByVal e As EventArgs) Handles cmdSave.Click

'-- Check the rules on the business object. We are not going to save

'-- until we get all the way back to the parent form. A save could

'-- be executed here if necessary, however, since this is a child

'-- form, the parent form usually controls the saves. The true

'-- will show the InfoBox error window if the rules are broken.

If CustomerNotes.CheckRulesOnRow(True) Then

Me.DialogResult = System.Windows.Forms.DialogResult.OK

End If

End Sub

[/codesnippet][/quote]

The CheckRulesOnRow(True) is not working in a sense that is not showing the required fields nor showing the InfoBox to inform the user that there is a problem with that record, but it is not entering the IF condition which mean that it is partially working.

How can I deal with this situation since in all my ChildForms I need to check for broken rules defined in the BO class?

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Thu, 22 May 2008 13:02:22 GMT

Really, we didn't even do that in VFP (bad word, I know :D). We used table buffering and didn't commit the changes until down stream. Granted, it was nowhere as clean as using the BOs and disconnected data, but the concept was really the same.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Thu, 22 May 2008 11:32:13 GMT

Hi Trent,

After your post, I when to check the SF Samples and after reviewing the ChildDialogFormSample.sln I think I now have a better understanding of this concept of drilling down child forms and having control of all the savings from a single point.

I must admit that it still scares me a bit :cool: drilling down several child forms without saving and potentially undo some data that the end user may not wanted to undo, but I guess is just a matter of understanding the design purpose of the ChildFormDialog control.

I'll keep you posted :hehe:

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Wed, 21 May 2008 22:16:58 GMT

[quote]So basically all child BO should be Saved when clicking the Save button in the Parent Form?[/quote]

Yes. All Save and Undo logic should occur from a single point (not the child form :) ) but the most common place would be the Parent form or container.

[quote]I guess that if I select Undo from the toolbar that all child data will be undoed?[/quote]

Yup...you got it :)

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 21 May 2008 20:03:11 GMT

[quote][b]Trent L. Taylor (05/21/2008)[/b][hr]In one maintenance form that I recently finished, I have 11 child and grandchild records that could be created on a new record without ever first requiring a parent record to first be saved. So that is the first thing I would rework versus forcing the save of the parent.[/quote]

So basically all child BO should be Saved when clicking the Save button in the Parent Form?
I guess that if I select Undo from the toolbar that all child data will be undoed?

Guess I am still thinking as a VFP developer :D

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Wed, 21 May 2008 19:35:04 GMT

[quote]Point taken, then where to put the save code then? In the ChildForm I am making a reference to the ParentBO PK field value which will be -1 if not saved and brake the code. Any suggestion?[/quote]

This is the whole point of a parent relationship. You SHOULD be able to create a child record on a parent that doesn't yet have a PK yet. SF will automatically persist the parent's PK to the child once the parent gets a PK. So you should be saving these records at the same time. It isn't fair to require the end-user to save a parent record before a child gets created. All of this should be able to be done at the same time.

In one maintenance form that I recently finished, I have 11 child and grandchild records that could be created on a new record without ever first requiring a parent record to first be saved. So that is the first thing I would rework versus forcing the save of the parent.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 21 May 2008 18:09:11 GMT

[quote][b]Trent L. Taylor (05/21/2008)[/b][hr]...and FYI...saving within that event could come back and slap you at some point...this is generally never a good idea.[/quote]

Point taken, then where to put the save code then? In the ChildForm I am making a reference to the ParentBO PK field value which will be -1 if not saved and brake the code. Any suggestion?

[quote]So However, it might not be a bad idea to have a BeforeShowChildDialog event on the ListView so that you could cancel it if you like.[/quote]

That sounds good. :hehe:

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Wed, 21 May 2008 17:09:56 GMT

That cancel flag doesn't logically tie into the BOs BeforeAddNew...so the cancel will not have any affect in this case. That Cancel only has to do with adding a new row to the BO...and FYI...saving within that event could come back and slap you at some point...this is generally never a good idea.

However, it might not be a bad idea to have a BeforeShowChildDialog event on the ListView so that you could cancel it if you like.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 21 May 2008 13:56:52 GMT

Hi Trent,

I have another situation with the ListView, I guess :D

I am using the HandleAddAction = True to let the ListView calling the ChildForm when adding. I added the code below to cancel the Adding if the Save() of the parent BO is not Success, but even though I am setting the e.Cancel = True, the ChildForm is being shown. Am I using the correct logic here?

[quote][codesnippet]

Private Sub Child_PolicyBO1_BeforeAddNew(ByVal e As MicroFour.StrataFrame.Business.BeforeAddNewEventArgs) Handles Child_PolicyBO1.BeforeAddNew

If Me.InsuredCustomerBO1.IsDirty Then

If Me.Save() <> MicroFour.StrataFrame.Data.SaveUndoResult.Success Then

e.Cancel = True

End If

End Sub

[/codesnippet][/quote]

P.S.

FYI, since the ListView enhancements are still in beta, I keep posting in this thread to keep everything related to this in one place, if you prefer I can post this kind of stuff in a separate thread.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Tue, 06 May 2008 15:20:04 GMT

Trent,

[quote]Just because you get an error to go away doesn't mean that the problem is fixed.[/quote]

I do understand what you are saying and respect your policies. But so we are in the same page here let me clarify the problem a little bit:

The ListView enhancement is in beta and I am using this control a lot.
When testing the Delete functionality I noticed that the record was only marked as deleted, and could not find a way to change this behavior without disabling the HandleDeleteAction and adding a custom code for all ListView used in this form.
Since the mark as deleted will required a call to the BO.Save() to permanently delete the record, then I tried to do that and got the error reported.
Based on the test you asked me to do, by calling the BO.DeleteCurrentRow(False) will work fine, then I make the suggestion to add the property to control how the DeleteCurrentRow will behave.

I am trying to move forward with this project and have not problem to take the time to investigate any problem, in fact I spend a lot of time in the forums before posting to try to get answers to my stituations, but I do really need to be ready to show this project to the customer anytime soon. So for now I will simply add a common DeleteRecord method for my ListViews.:hehe:

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Tue, 06 May 2008 14:54:58 GMT

Edhy,

Let me just point out something when we address a problem...we first try to get to the source of an issue before we add a new feature. Just because you get an error to go away doesn't mean that the problem is fixed. Adding a property is not big deal and I have no issue doing this at some point...so just because I don't immediately say, "I will go add this right now!" doesn't mean that it has no merit...it just means that it doesn't get to the crux of the issue.

If you look at your stack trace, something was trying to bind or pull from the CurrentRow...which could be related to the code in the ListView possibly and we may need to setup a test. Thus I suggested the manual code change to see if something else arose. I will see if I can reproduce the error, but until I prove the error, I will not add a property. It is more important for me to understand why there was an error so that something else is not introduced versus just providing a fix that may prevent the error but we don't know why.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Tue, 06 May 2008 14:05:03 GMT

I did the test as follow and it worked just fine, of course passing the False to the DeleteCurrentRow() method does not requires me to Save() the record :

[quote][codesnippet]

Private Sub cmdDelete_Policy_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdDelete_Policy.Click

'-- If no business object is attached then there is nothing to do

If Me.Child_PolicyBO1 Is Nothing Then Exit Sub

'-- Ensure the the correct record is selected in case it had been moved by the developer

Me.Child_PolicyBO1.NavigateToPrimaryKey(Me.lvPolicy.SelectedItems(0).Tag)

'-- If we are here, then delete the record

Me.Child_PolicyBO1.DeleteCurrentRow(False)

'-- Requery this list

Me.lvPolicy.Requery()

End Sub

[/codesnippet][/quote]

Like I said before I think that a new property in the ListView to flag the DeleteChildRecord() as OnlyMarkAsDeleted or not, will take care of this situation and will not require us to add more code to the form whenever the ListView is used and the Delete action needs to be permanent.

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Tue, 06 May 2008 13:49:38 GMT

Your error has less to do with the delete than it does binding it would appear. Something is trying to reference the CurrentRow property of the BO, thus the error.

To prove it, and to do this yourself, just set the HandleDeleteAction to false and manually delete the record...it should already be on the correct record, etc.

[codesnippet]MyBo.DeleteCurrentRow(False)[/codesnippet]

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Tue, 06 May 2008 13:27:41 GMT

Trent,

The DeleteChildRecord() method of the ListView is marking the records as deleted which then will require a Save() to actually delete the record.

[codesnippet]

'-- If we are here, then delete the record

_BusinessObject.DeleteCurrentRow(True)

[/codesnippet]

In my form which uses 3 ListViews in the same fashion I have the need to permanently delete the record when the DeleteChildRecord() is being executed. I tried adding code in the BO_AfterDelete() event to save this child BO but I am getting an error:

[quote][codesnippet]

Private Sub Child_PolicyBO1_AfterDelete(ByVal e As MicroFour.StrataFrame.Business.AfterDeleteEventArgs) Handles Child_PolicyBO1.AfterDelete

If e.RowsAffected > 0 Then

Me.Child_PolicyBO1.Save()

End If

End Sub

[/codesnippet][/quote]

This is the error:

[quote]BusinessLayerException
An error occurred while saving the data to the server.
IndexOutOfRangeException
Index 0 is either negative or above rows count.

Source : MicroFour StrataFrame Business

Stack Trace:
   at System.Data.DataView.GetRow(Int32 index)
   at System.Data.DataView.get_Item(Int32 recordIndex)
   at MicroFour.StrataFrame.Business.BusinessLayer.get_CurrentRow()
   at MicroFour.StrataFrame.Business.BusinessLayer.FilterChildRecords(BusinessLayer ChildBusinessObject)
   at MicroFour.StrataFrame.Business.BusinessLayer.Save(Boolean Transactional, String TransactionKey)
   at MicroFour.StrataFrame.Business.BusinessLayer.Save()
   at IBS_UI.frmInsuredCustomer.Child_PolicyBO1_AfterDelete(AfterDeleteEventArgs e) in E:\Visual Studio 2008 Projects\StrataFrame\Insurance Broker System (SF)\UI\Main Forms\frmInsuredCustomer.vb:line 226
   at MicroFour.StrataFrame.Business.BusinessLayer.AfterDeleteEventHandler.Invoke(AfterDeleteEventArgs e)
   at MicroFour.StrataFrame.Business.BusinessLayer.raise_AfterDelete(AfterDeleteEventArgs e)
   at MicroFour.StrataFrame.Business.BusinessLayer.OnAfterDelete(AfterDeleteEventArgs e)
   at MicroFour.StrataFrame.Business.BusinessLayer.DeleteCurrentRow(Boolean CheckSecurity, Boolean OnlyMarkAsDeleted)
   at MicroFour.StrataFrame.Business.BusinessLayer.DeleteCurrentRow(Boolean OnlyMarkAsDeleted)
   at MicroFour.StrataFrame.UI.Windows.Forms.ListView.DeleteChildRecord()
   at MicroFour.StrataFrame.UI.Windows.Forms.ListView.HandleObjectClick(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativewindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativewindow.WndProc(Message& m)
   at System.Windows.Forms.Nativewindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
[/quote]

Where should I call the BO.Save() to permanent delete the record?

P.S.

I think that a new property in the ListView to flag the DeleteChildRecord() as OnlyMarkAsDeleted or not, may be an easy way to solve this.

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 30 Apr 2008 11:05:00 GMT

Thanks Trent.

RE: Beta 1.6.5.1: ListView enhanced features....

Trent L. Taylor — Wed, 30 Apr 2008 10:50:24 GMT

Sure, I just changed the UpdateObjectStates method to this:

[codesnippet]''' <summary>
''' Updates the objects states based on the selected state of the list items and security
''' </summary>
''' <remarks></remarks>
Private Sub UpdateObjectStates()
    '-- Establish Locals
    Dim isSelected As Boolean = Me.SelectedItems.Count > 0
    Dim isAddAllowed As Boolean = HasPermission(_AddObjectSecurityKey)
    '-- Determine if additional logic should be performed to determine the add status
    If (_BusinessObject IsNot Nothing) AndAlso _
       (_BusinessObject.ParentBusinessObject IsNot Nothing) AndAlso _
       isAddAllowed Then
        isAddAllowed = _BusinessObject.ParentBusinessObject.Count > 0
    End If
    If _AddObject IsNot Nothing Then SetObjectEnabledState(_AddObject, isAddAllowed)
    If _EditObject IsNot Nothing Then SetObjectEnabledState(_EditObject, isSelected AndAlso HasPermission(_EditObjectSecurityKey))
    If _DeleteObject IsNot Nothing Then SetObjectEnabledState(_DeleteObject, isSelected AndAlso HasPermission(_DeleteObjectSecurityKey))
End Sub[/codesnippet]

RE: Beta 1.6.5.1: ListView enhanced features....

Edhy Rijo — Wed, 30 Apr 2008 10:40:45 GMT

[quote][b]Trent L. Taylor (04/30/2008)[/b][hr]Actually, I just tested it and it DOES fix the problem.[/quote]

Hi again,

Yes IT DOES WORK, sorry but my quick sample project was too quick :D and not setup properly, but after testin in my actual project it did work and then after adding all the missing setp in the quick project it also worked.

If you don't mind, could you tell me what was changed in the source code?