Looks good, just make sure that when you throw the exception from within the handlers, that you include the supplied exception as an inner exception in case you need to get back to the stack trace some how.

I really appreciate all your help. This is what I finally came up with. I'm going to put this on all of our base business objects.

The 2 Handler functions basically write to the event log and then rethrow a custom exception to the presentation layer.

Cool...thanks Ben

I was just saying that when you create a new business object from our template, it will inherit from BusinessLayer, so you will need to change it so that it inherits from your class, not BusinessLayer.  The base class that you create will be excactly like you mentioned... it's a basic business object (that itself will inherit from BusinessLayer).

Well, actually, the business object isn't going to ever return FailedWithExceptions from save()...

If an exception is encountered from within the save, then the exception will just be bubbled up if the ErrorSavingMode is FailOnError and the return value will be CompletedWithExceptions if the ErrorSavingMode is ContinueOnError.  If ContinueOnError is used, then yes, the ErrorSaving event will contain the exceptions thrown. 

So, the FailedWithExceptions is used for the SaveByForm() method, not the Save() method.  So, if you're going to be saving all of the business objects at once through the form's Save() method, then I you would want to override the SaveByForm() method and do the same thing (but I don't think that one is overridable, so if you're saving through the form's Save() method, then we might need to work out something different).

Hi Ben

I'm not tracking on this part...

I generally create my own base classes using your templates then inherit from those.

Thanks Ben

Is the ErrorSaving event the only place I can examine the exceptions that cause FailedWithExceptions?

 

Yep, looks good to me.  Centralizes everything nice and neat.  Just make sure to change the Inherits line (or the : line) when you create a new business object from our template.

Hi Ben

This is what I've come up with...what do you think?

Public Overrides Function Save(ByVal b As Boolean) As MicroFour.StrataFrame.Data.SaveUndoResult

Dim r As MicroFour.StrataFrame.Data.SaveUndoResult

r = MyBase.Save(b)

If Not (r = MicroFour.StrataFrame.Data.SaveUndoResult.Success OrElse _

r = MicroFour.StrataFrame.Data.SaveUndoResult.Cancelled OrElse _

r = MicroFour.StrataFrame.Data.SaveUndoResult.CompletedWithExceptions) Then

Select Case r

Case MicroFour.StrataFrame.Data.SaveUndoResult.AbortedWithBrokenRules

Dim strJson As String = LitJson.JsonHelper.WriteJsonString(Me.BrokenRules)

Utility.SystemUtilities.ErrHandler.WriteEventLog(strJson, "", Diagnostics.EventLogEntryType.Error)

Throw New Exceptions.BrokenRulesException(strJson)

Case MicroFour.StrataFrame.Data.SaveUndoResult.FailedWithExceptions

Throw New ApplicationException()

End Select

End If

End Function

Well, the ErrorSaving event only catches exceptions that are caused during the save, and only if the ErrorSavingMode is set to ContinueOnError.  Your best bet would be to create a BoBase class and override the OnBusinessRulesChecked method.  If the business rules are broken, then throw your exception containing the business rules. 

Another option would be to create the BoBase class and override Save().  Call MyBase.Save() and check the return value within your own Save() and check the select case there.  You could even show your form with the broken rules there if you don't mind taking that portion of the UI out of the UI...