Took you long enough!!!! Jeez almost an hour .. J/K 

Thanks alot Trent as usual you are on top of it

Done.  I added a test on the PositionLabels and PositionControls to prevent the error if there are no search fields visible within the dialog.  It will be in the next build posted.

Trent,

The line where it is failing is.

Dim lnTextHeight As Integer = _Controls.Item(0).Height

What happened was there were no search fields visible in the key so the add labels was crashing due because the controls collection was empty. I dont know why they were not visible i guess i must have been screwing around with them.

could you test for this condition (no search fields visible) and allow a browse dialog to come up without visible search fields and allow the user to then add search fields? It sure beats crashing  

Thanks alot Paul

That would have been nice, huh   We actually have a lot of BD's in our medical software as well that use the very same approach that you are in regards to a Browse Base and then inherit from that base BD.  And we have not noticed any issues....so you might just want to build the source in debug mode.

I have just posted a new build in the last minute or so as well as the source code for that build in the My Account area.  So you may want to build the source in debug mode so that you can see where it is breaking. 

Hiya Trent,

I'm using inherited standard SF browse dialogs. For instance I have customerbrowse which in inherits from browse base and EmployeeBrowse which also inherits from browse base. Customer browse works fine but employee bombs, I have several BD's that work and several that do not although all of them did work last release and I haven't changed the browse dialog or the base class in quite awile but I may have changed something else that is making them spit up I am just not sure what on earth it may be that I changed that would cause this. 

I will spend some time poking around and start from the bottom and work my way up till I find the problem i was just hoping you would say oh yeah we know what that is just set the don't crash property to true and you'll be fine.

A couple of things here.  First, are you using the standard StrataFrame BrowseDialogs or the DevExpress Wrapper?  Secondly, I was looking and this method hasn't been changed in a very long time...so...we may need to start looking at your environment.  Also, one thing you might try, just for grins, is to create a temp form and drop on a BrowseDialog and see if the error persists on a new browse...the only reason for this is to see if the error pops up immediately here which will give us more to go on when working through your problem.

I don't know when or how it happened, but for whatever reason a few of my browse dialogs are crashing with the error below. I have not made any changes to any individual browse dialogs in a very very long time. I know that these browse dialogs worked fine on my last release as it is currently in production and I can't think of anything that I changed since then that might cause this problem.  

 Any ideas on what to look at on this