Using DataBasics to execute a non-bo-bound stored procedure


Author
Message
Greg McGuffey
Greg McGuffey
Strategic Support Team Member (3.3K reputation)
Group: Forum Members
Posts: 2K, Visits: 6.6K
LOL! Glad you found a solution to your issue though!
Alex Luyando
Alex Luyando
StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)StrataFrame User (210 reputation)
Group: StrataFrame Users
Posts: 112, Visits: 1.2K
Greg McGuffey (08/26/2008)
I'm wondering if the problem is that you are using Return instead of Select. My understanding is that Return is used to return a status code, while you'd use Select to return a record set, which ExecuteScalar will then retrieve data from.




How I wish I had read this about two hours earlier! LOL



Very handy to know.. Thanks!

________________
_____/ Regards,
____/ al
Greg McGuffey
Greg McGuffey
Strategic Support Team Member (3.3K reputation)
Group: Forum Members
Posts: 2K, Visits: 6.6K
Glad you got it working and that I was of help! BigGrin
Philipp Guntermann
Philipp Guntermann
StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)
Group: Forum Members
Posts: 141, Visits: 263
Just letting you know it does indeed work now using SELECT instead of RETURN.

Thanks again to Greg for pointing this out. Smile

Dustin Taylor
Dustin Taylor
StrataFrame Team Member (652 reputation)
Group: StrataFrame Users
Posts: 364, Visits: 771
Yep, greg nailed it. Even though it is a scalar, you still want to return a recordset, hence the need for a SELECT.

RETURN will exit the code loop immediately. It can return an integer, but that is typically used to show success or failure and isn't what you are looking for in this case.

Michel Levy
Michel Levy
StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)StrataFrame User (437 reputation)
Group: StrataFrame Users
Posts: 193, Visits: 9K
Philipp,

Using a BO is for a maintenance purpose (All the business code is in the BO, all the connections against SQL server run from a BO to DL)

And the intermediate SP (or execute as.. revert) is for a security purpose: I never expose a SP directly in the AppUser schema.

Philipp Guntermann
Philipp Guntermann
StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)
Group: Forum Members
Posts: 141, Visits: 263
hi,

thanks. that seems like it could be the problem. i wasnt aware of the use of select instead of return.

i will try changing it when i get back to work tommorow.

Greg McGuffey
Greg McGuffey
Strategic Support Team Member (3.3K reputation)
Group: Forum Members
Posts: 2K, Visits: 6.6K
I'm wondering if the problem is that you are using Return instead of Select. My understanding is that Return is used to return a status code, while you'd use Select to return a record set, which ExecuteScalar will then retrieve data from. So change:



RETURN @iKassenId




to



Select @iKassenId




and see if that works. I'm guessing that since you don't select anything, either null or DdNull.Value is being returned from execute scalar.



You might also want to check for conditions like this in code. Something like:



object result = DataBasics.DataSources[""].ExecuteStoredProcedure("spK_KassenAnmeldung", DbCommandExecutionType.ExecuteScalar, spParams);

if result != null && result != DbNull.Value

{

return (int)result;

}

else

{

// return default or throw an exception

return 0

}


Philipp Guntermann
Philipp Guntermann
StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)StrataFrame User (231 reputation)
Group: Forum Members
Posts: 141, Visits: 263
Hi Dustin,

this is my sproc:

set ANSI_NULLS ON

set QUOTED_IDENTIFIER ON

GO

ALTER PROCEDURE [dbo].[spK_KassenAnmeldung]

@HWID VARCHAR(250),

@ComputerName VARCHAR(250)

AS

DECLARE @iKassenId int

SET @iKassenId = ( SELECT TOP 1 ID FROM tbKassen WHERE

HWID = @HWID AND ComputerName = @ComputerName );

IF ( @iKassenId IS NULL )

BEGIN

DECLARE @iKassenNr int;

SET @iKassenNr = ( SELECT count(*) FROM tbKassen );

INSERT INTO tbKassen (Bezeichnung, Zyklus, HWID, ComputerName)

VALUES ('Kasse'+LTRIM(STR(@iKassenNr)) , 0, @HWID, @ComputerName);

SET @iKassenId = SCOPE_IDENTITY();

END

RETURN @iKassenId


Dustin Taylor
Dustin Taylor
StrataFrame Team Member (652 reputation)
Group: StrataFrame Users
Posts: 364, Visits: 771
Your code looks good. What is in your stored procedure?

I just made a test that comes accross fine using the StrataFrame sample. Here is my SF code:

Dim spParams As System.Data.Common.DbParameter() = {New System.Data.SqlClient.SqlParameter}
spParams(0).ParameterName = "@cust_pk"
spParams(0).Value = "1"
Dim test As String = MicroFour.StrataFrame.Data.DataBasics.DataSources("").ExecuteStoredProcedure("GetCustomerLastName", MicroFour.StrataFrame.Data.DbCommandExecutionType.ExecuteScalar, spParams)

And here is the alter for my stored procedure:

set ANSI_NULLS ON
set QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[GetCustomerLastName]
-- Add the parameters for the stored procedure here
@cust_pk int = 1
AS
BEGIN
-- Insert statements for procedure here
SELECT cust_LastName FROM Customers WHERE cust_pk = @cust_pk
END

 


GO

Merge Selected

Merge into selected topic...



Merge into merge target...



Merge into a specific topic ID...




Similar Topics

Reading This Topic

Login

Explore
Messages
Mentions
Search